On Thu, Jan 10, 2013 at 05:09:43PM -0700, Stephen Warren wrote:
> On 01/09/2013 01:43 PM, Thierry Reding wrote:
> > This function can be used to parse the device and function number from a
> > standard 5-cell PCI resource. PCI_SLOT() and PCI_FUNC() can be used on
> > the returned value obtain the device and function numbers respectively.
>
> > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c
>
> > static inline int __of_pci_pci_compare(struct device_node *node,
> > unsigned int devfn)
> > {
> > + int err;
> >
> > + err = of_pci_get_devfn(node);
> > + if (err < 0)
> > return 0;
> > +
> > + return devfn == err;
>
> I know this is really picky, but calling that "err" when it's hopefully
> not an error but rather a PCI device/function ID seems a little obscure.
> Perhaps node_devfn? I assume that fact that devfn is unsigned and err is
> signed won't be an issue.Maybe renaming the devfn parameter to data and using devfn for the local variable would be more obvious. The signedness shouldn't be problematic. devfn is an 8-bit unsigned integer and sign mismatch is excluded by the error return already. Thierry
pgpSd96sMkIJ5.pgp
Description: PGP signature
