On Thu, Jan 17, 2013 at 04:46:16PM -0800, Greg Kroah-Hartman wrote: > On Thu, Jan 17, 2013 at 06:07:11PM -0200, Herton Ronaldo Krzesinski wrote: > > On Tue, Jan 15, 2013 at 02:54:33PM -0800, Greg Kroah-Hartman wrote: > > > 3.0-stable review patch. If anyone has any objections, please let me > > > know. > > > > > > ------------------ > > > > > > From: Theodore Ts'o <ty...@mit.edu> > > > > > > commit 721e3eba21e43532e438652dd8f1fcdfce3187e7 upstream. > > > > > > Commit c278531d39 added a warning when ext4_flush_unwritten_io() is > > > called without i_mutex being taken. It had previously not been taken > > > during orphan cleanup since races weren't possible at that point in > > > the mount process, but as a result of this c278531d39, we will now see > > > a kernel WARN_ON in this case. Take the i_mutex in > > > ext4_orphan_cleanup() to suppress this warning. > > > > > > Reported-by: Alexander Beregalov <a.berega...@gmail.com> > > > Signed-off-by: "Theodore Ts'o" <ty...@mit.edu> > > > Reviewed-by: Zheng Liu <wenqing...@taobao.com> > > > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> > > > > By the description and looking at commit c278531d39, this change isn't > > needed for 3.0 or 3.4 kernels (anything <= 3.6), they don't contain > > commit c278531d39. > > Ah, good catch. Should this be reverted from 3.0 and 3.4?
I judge it as unecessary from what I saw so far, can ext4 developers and/or people in Cc confirm? It should be harmless, only consequence is an uneeded lock being taken now in 3.0/3.4 > > thanks, > > greg k-h > -- []'s Herton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
