On Wed, 30 Jan 2013, Mark Einon wrote: > >> > >> This patch fixes the kernel warning generated when putting an MSI > >> > >> MS-1727 > >> > >> GT740 laptop into suspend mode. The call sequence in this case calls > >> > >> free_irq() twice, once in pci_remove() and once then in pci_suspend(). > >> > > > >> > > You mean /first/ in pci_suspend() and /then/ in pci_remove() on the > >> > > already suspended devices, right? > >> > > >> > Yes, I did. The call sequence is suspend then resume. My bad. > > > > Why does the pci_suspend routine call free_irq() at all? As far as I > > know, it's not supposed to do that. Won't the device continue to use > > the same IRQ after it is resumed? > > This sounds reasonable to me - I think we could probably get rid of > the request_irq() call from resume, and use > disable_irq()/enable_irq()?
Why mess around with IRQ settings at all? Just have the suspend routine tell the controller to stop generating them. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
