On Sun, Feb 10, 2013 at 01:22:43PM +0800, Hillf Danton wrote: > In cpu_stopper_thread(), @work->done may be NULL if the cpu stop work > is queued from stop_one_cpu_nowait(); however, cpu_stopper_thread() > updates @done->ret without checking whether @done exists or not when > the work function fails. > > While this can lead to oops, the only current user of > stop_one_cpu_nowait() - active_load_balance_cpu_stop() - always > returns 0 and thus there's no in-kernel user which triggers this bug. > > Fix it by checking whether @done exists before updating @done->ret. > > Thanks Tejun for sharing commit message. > > Signed-off-by: Hillf Danton <[email protected]> > Reviewed-by: Namhyung Kim <[email protected]>
Acked-by: Tejun Heo <[email protected]> Andrew, can you please take this? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
