From: Graeme Gregory <g...@slimlogic.co.uk>

Read the chip varient and the OTP information from the chip and display
this on probe to aid in debugging of issues.

Older palmas chips do not have the USB_ID programmed and will therefore
return 0x0000 for this field.

Signed-off-by: Graeme Gregory <g...@slimlogic.co.uk>
Signed-off-by: Ian Lartey <i...@slimlogic.co.uk>
---
 drivers/mfd/palmas.c       |   49 ++++++++++++++++++++++++++++++++++++++++++++
 include/linux/mfd/palmas.h |   38 ++++++++++++++++++++++++++++++++++
 2 files changed, 87 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index bbdbc50..2bca666 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -4,6 +4,7 @@
  * Copyright 2011-2012 Texas Instruments Inc.
  *
  * Author: Graeme Gregory <g...@slimlogic.co.uk>
+ * Author: Ian Lartey <i...@slimlogic.co.uk>
  *
  *  This program is free software; you can redistribute it and/or modify it
  *  under  the terms of the GNU General  Public License as published by the
@@ -344,6 +345,54 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
                }
        }
 
+       /* Read varient info from the device */
+       slave = PALMAS_BASE_TO_SLAVE(PALMAS_ID_BASE);
+       addr = PALMAS_BASE_TO_REG(PALMAS_ID_BASE, PALMAS_PRODUCT_ID_LSB);
+       ret = regmap_read(palmas->regmap[slave], addr, &reg);
+       if (ret < 0) {
+               dev_err(palmas->dev, "Unable to read ID err: %d\n", ret);
+               goto err;
+       }
+
+       palmas->id = reg;
+
+       slave = PALMAS_BASE_TO_SLAVE(PALMAS_ID_BASE);
+       addr = PALMAS_BASE_TO_REG(PALMAS_ID_BASE, PALMAS_PRODUCT_ID_MSB);
+       ret = regmap_read(palmas->regmap[slave], addr, &reg);
+       if (ret < 0) {
+               dev_err(palmas->dev, "Unable to read ID err: %d\n", ret);
+               goto err;
+       }
+
+       palmas->id |= reg << 8;
+
+       dev_info(palmas->dev, "Product ID %x\n", palmas->id);
+
+       slave = PALMAS_BASE_TO_SLAVE(PALMAS_DESIGNREV_BASE);
+       addr = PALMAS_BASE_TO_REG(PALMAS_DESIGNREV_BASE, PALMAS_DESIGNREV);
+       ret = regmap_read(palmas->regmap[slave], addr, &reg);
+       if (ret < 0) {
+               dev_err(palmas->dev, "Unable to read DESIGNREV err: %d\n", ret);
+               goto err;
+       }
+
+       palmas->designrev = reg & PALMAS_DESIGNREV_DESIGNREV_MASK;
+
+       dev_info(palmas->dev, "Product Design Rev %x\n", palmas->designrev);
+
+       slave = PALMAS_BASE_TO_SLAVE(PALMAS_PMU_CONTROL_BASE);
+       addr = PALMAS_BASE_TO_REG(PALMAS_PMU_CONTROL_BASE, PALMAS_SW_REVISION);
+       ret = regmap_read(palmas->regmap[slave], addr, &reg);
+       if (ret < 0) {
+               dev_err(palmas->dev, "Unable to read SW_REVISION err: %d\n",
+                               ret);
+               goto err;
+       }
+
+       palmas->sw_revision = reg;
+
+       dev_info(palmas->dev, "Product SW Rev %x\n", palmas->sw_revision);
+
        /* Change IRQ into clear on read mode for efficiency */
        slave = PALMAS_BASE_TO_SLAVE(PALMAS_INTERRUPT_BASE);
        addr = PALMAS_BASE_TO_REG(PALMAS_INTERRUPT_BASE, PALMAS_INT_CTRL);
diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
index a4d13d7..2e8b747 100644
--- a/include/linux/mfd/palmas.h
+++ b/include/linux/mfd/palmas.h
@@ -4,6 +4,7 @@
  * Copyright 2011 Texas Instruments Inc.
  *
  * Author: Graeme Gregory <g...@slimlogic.co.uk>
+ * Author: Ian Lartey <i...@slimlogic.co.uk>
  *
  *  This program is free software; you can redistribute it and/or modify it
  *  under  the terms of the GNU General  Public License as published by the
@@ -22,6 +23,10 @@
 
 #define PALMAS_NUM_CLIENTS             3
 
+/* The ID_REVISION NUMBERS */
+#define PALMAS_CHIP_OLD_ID             0x0000
+#define PALMAS_CHIP_ID                 0xC035
+
 struct palmas_pmic;
 struct palmas_gpadc;
 struct palmas_resource;
@@ -35,6 +40,8 @@ struct palmas {
 
        /* Stored chip id */
        int id;
+       int designrev;
+       int sw_revision;
 
        /* IRQ Data */
        int irq;
@@ -427,11 +434,13 @@ enum usb_irq_events {
 #define PALMAS_PU_PD_OD_BASE                                   0x1F4
 #define PALMAS_LED_BASE                                                0x200
 #define PALMAS_INTERRUPT_BASE                                  0x210
+#define PALMAS_ID_BASE                                         0x24F
 #define PALMAS_USB_OTG_BASE                                    0x250
 #define PALMAS_VIBRATOR_BASE                                   0x270
 #define PALMAS_GPIO_BASE                                       0x280
 #define PALMAS_USB_BASE                                                0x290
 #define PALMAS_GPADC_BASE                                      0x2C0
+#define PALMAS_DESIGNREV_BASE                                  0x357
 #define PALMAS_TRIM_GPADC_BASE                                 0x3CD
 
 /* Registers for function RTC */
@@ -2149,6 +2158,28 @@ enum usb_irq_events {
 #define PALMAS_INT_CTRL_INT_CLEAR                              0x01
 #define PALMAS_INT_CTRL_INT_CLEAR_SHIFT                                0
 
+/* Registers for function ID */
+#define PALMAS_VENDOR_ID_LSB                                   0x0
+#define PALMAS_VENDOR_ID_MSB                                   0x1
+#define PALMAS_PRODUCT_ID_LSB                                  0x2
+#define PALMAS_PRODUCT_ID_MSB                                  0x3
+
+/* Bit definitions for VENDOR_ID_LSB */
+#define PALMAS_VENDOR_ID_LSB_VENDOR_ID_MASK                    0xff
+#define PALMAS_VENDOR_ID_LSB_VENDOR_ID_SHIFT                   0
+
+/* Bit definitions for VENDOR_ID_MSB */
+#define PALMAS_VENDOR_ID_MSB_VENDOR_ID_MASK                    0xff
+#define PALMAS_VENDOR_ID_MSB_VENDOR_ID_SHIFT                   0
+
+/* Bit definitions for PRODUCT_ID_LSB */
+#define PALMAS_PRODUCT_ID_LSB_PRODUCT_ID_MASK                  0xff
+#define PALMAS_PRODUCT_ID_LSB_PRODUCT_ID_SHIFT                 0
+
+/* Bit definitions for PRODUCT_ID_MSB */
+#define PALMAS_PRODUCT_ID_MSB_PRODUCT_ID_MASK                  0xff
+#define PALMAS_PRODUCT_ID_MSB_PRODUCT_ID_SHIFT                 0
+
 /* Registers for function USB_OTG */
 #define PALMAS_USB_WAKEUP                                      0x3
 #define PALMAS_USB_VBUS_CTRL_SET                               0x4
@@ -2771,6 +2802,13 @@ enum usb_irq_events {
 #define PALMAS_GPADC_SMPS_VSEL_MONITORING_SMPS_VSEL_MONITORING_MASK    0x7f
 #define PALMAS_GPADC_SMPS_VSEL_MONITORING_SMPS_VSEL_MONITORING_SHIFT   0
 
+/* Registers for function DESIGNREV */
+#define PALMAS_DESIGNREV                                       0x0
+
+/* Bit definitions for DESIGNREV */
+#define PALMAS_DESIGNREV_DESIGNREV_MASK                                0x0f
+#define PALMAS_DESIGNREV_DESIGNREV_SHIFT                       0
+
 /* Registers for function GPADC */
 #define PALMAS_GPADC_TRIM1                                     0x0
 #define PALMAS_GPADC_TRIM2                                     0x1
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to