On Fri, Feb 22, 2013 at 4:56 AM, Marcelo Tosatti <mtosa...@redhat.com> wrote: > On Thu, Feb 21, 2013 at 09:56:54AM +0100, Ingo Molnar wrote: >> >> * Shuah Khan <shuahk...@gmail.com> wrote: >> >> > On Tue, Feb 19, 2013 at 7:27 PM, Linux Kernel Mailing List >> > <linux-kernel@vger.kernel.org> wrote: >> > > Gitweb: >> > > http://git.kernel.org/linus/;a=commit;h=c3c186403c6abd32e719f005f0af950155a9e54d >> > > Commit: c3c186403c6abd32e719f005f0af950155a9e54d >> > > Parent: e0a79f529d5ba2507486d498b25da40911d95cf6 >> > > Author: Dan Carpenter <dan.carpen...@oracle.com> >> > > AuthorDate: Tue Feb 5 14:37:51 2013 +0300 >> > > Committer: Ingo Molnar <mi...@kernel.org> >> > > CommitDate: Tue Feb 5 12:59:29 2013 +0100 >> > > >> > > sched: Fix signedness bug in yield_to() >> > > >> > > In 7b270f6099 "sched: Bail out of yield_to when source and >> > > target runqueue has one task" we changed this to store -ESRCH so >> > > it needs to be signed. >> > >> > Dan, Ingo, >> > >> > I can't find the 7b270f6099 "sched: Bail out of yield_to when >> > source and target runqueue has one task" in the latest Linus's >> > git. Am I missing something. >> > >> > The current kenel/sched/core.c doesn't have the code from the >> > associated patch https://patchwork.kernel.org/patch/2016651/ >> >> As per the lkml discussion that one was supposed to go upstream >> via the KVM tree. Marcelo? > > commit c3c186403c6abd32e719f005f0af950155a9e54d > Author: Dan Carpenter <dan.carpen...@oracle.com> > Date: Tue Feb 5 14:37:51 2013 +0300 > > sched: Fix signedness bug in yield_to() > > In 7b270f6099 "sched: Bail out of yield_to when source and > target runqueue has one task" we changed this to store -ESRCH so > it needs to be signed. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > Cc: Peter Zijlstra <pet...@infradead.org> > Cc: kbu...@01.org > Cc: Steven Rostedt <rost...@goodmis.org> > Cc: Mike Galbraith <efa...@gmx.de> > Link: http://lkml.kernel.org/r/20130205113751.GA20521@elgon.mountain > Signed-off-by: Ingo Molnar <mi...@kernel.org> >
IIUC, we are only changing variable in yield_to from bool to int. I am curious whether we need changes in struct sched_class (sched.h) bool (*yield_to_task) (struct rq *rq, struct task_struct *p, bool preempt); ==> int (*yield_to_task) (struct rq *rq, struct task_struct *p, bool preempt); otherwise we would assign bool value to int here yielded = curr->sched_class->yield_to_task(rq, p, preempt); this return values also cascaded to kvm_main.c. If we need to patchup entire thing, I can cook a correction patch. Thanks and Regards Raghu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/