On 02/22/2013 06:21 PM, Linus Walleij wrote: > On Fri, Feb 22, 2013 at 4:44 PM, Daniel Lezcano > <daniel.lezc...@linaro.org> wrote: > >> This patch fix the clock device irq field which is not initialized. >> >> Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> > > Makes perfect sense: > Acked-by: Linus Walleij <linus.wall...@linaro.org> > > Sorry that I might have missed some background here or just be > out-of-track with things, how did this driver work for years without > the irq assigned? Or was this field recently introduced?
The irq is assigned through: setup_irq(irq, &nmdk_timer_irq); two lines above but the clockevent's irq field was not set. I did not investigate a lot, but at the first glance it worked because the code path used by the default kernel configuration (CONFIG_NO_HZ) does not use this field. But when using the dynamic irq affinity [1], I noticed it was set to 0. [1] http://www.spinics.net/lists/arm-kernel/msg226371.html Thanks -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
