Hello, Ryan. On Wed, Mar 06, 2013 at 09:29:35AM +1100, Ryan Mallon wrote: > > @@ -148,6 +148,8 @@ struct worker_pool { > > struct mutex assoc_mutex; /* protect POOL_DISASSOCIATED */ > > struct ida worker_ida; /* L: for worker IDs */ > > > > + struct workqueue_attrs *attrs; /* I: worker attributes */ > > If attrs always exists, why not just embed the struct and avoid the > need to alloc/free it?
Because then it'll need a separate init paths for embedded ones. If the field was in any way hot, I'd have embedded it but it isn't and it's just less code to share the alloc path. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/