Em Wed, Mar 13, 2013 at 02:19:05PM +0100, Stephane Eranian escreveu: > On Thu, Mar 7, 2013 at 3:43 AM, Andi Kleen <[email protected]> wrote: > > > > + if (interval && csv_output) { > > + fprintf(output, "time,,"); > > Don't quite understand the point of the ,,. By definition this > extension is used for automatic > post-processing. I cannot find a good justification for the > double-comma, except for making
Yeah, that and the trailing comma as well, don't think they are needed. > reading the output easy. But that's contradictory with the gnuplot goal. > Also you need to add a # in front of this line to mark the line so it > can be discarded (as comment) > by any post-processing parser (such as gnuplot). > > > Also I think something needs to be improved for the non-aggregated output > in system-wide mode: > > $ perf stat -I 10000 -x, -a -A -e cycles,instructions sleep 5 > > Don't you want events also grouped by CPU? > > > Also noticed a bunch of trailing white spaces. I fixed those in the updated patch I sent. > I am not opposed to the idea of the patch, I think it is indeed useful > for post-processing tools. yeah - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
