Hi again,
On Thu, 14 Mar 2013 17:14:28 +0800, chenggang wrote:
> From: Chenggang Qin <chenggang....@taobao.com>
>
> If we execute "make clean" in perf's directory, many object files cannot be
> cleaned in the current version.
> For example:
> While we run "make clean" in perf's directory, and run the command:
> "fine ./ -name "*.o""
> we will get:
> ------------------------------------
> ./arch/x86/util/unwind.o
> ./arch/x86/util/header.o
> ./arch/x86/util/dwarf-regs.o
> ./util/scripting-engines/trace-event-python.o
> ./util/scripting-engines/trace-event-perl.o
> ./util/probe-finder.o
> ./util/dwarf-aux.o
> ./util/unwind.o
> ... ...
> ------------------------------------
> These ".o" files are not cleaned.
>
> The reason is:
> These object files are added into "BUILTIN_OBJS" while "make" process check
> the environment.
> If the make command is "clean", the environment check process is not
> executed. So,
> these object files will not be added into "BUILTIN_OBJS" while we execute
> "make clean".
s/BUILTIN/LIB/g
>
> This patch fixed this problem.
> We only add a command:
> "find . -name "*.o" -exec rm -f {} \;"
I think the path should be $(OUTPUT) rather than ".". How about this?
find $(OUTPUT) -name "*.o" -delete
Thanks,
Namhyung
>
> Cc: David Ahern <dsah...@gmail.com>
> Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
> Cc: Paul Mackerras <pau...@samba.org>
> Cc: Ingo Molnar <mi...@redhat.com>
> Cc: Arnaldo Carvalho de Melo <a...@ghostprotocols.net>
> Cc: Arjan van de Ven <ar...@linux.intel.com>
> Cc: Namhyung Kim <namhy...@gmail.com>
> Cc: Yanmin Zhang <yanmin.zh...@intel.com>
> Cc: Wu Fengguang <fengguang...@intel.com>
> Cc: Mike Galbraith <efa...@gmx.de>
> Cc: Andrew Morton <a...@linux-foundation.org>
> Signed-off-by: Chenggang Qin <chenggang....@taobao.com>
>
> ---
> tools/perf/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index a2108ca..dec08ba 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -1174,6 +1174,7 @@ clean: $(LIBTRACEEVENT)-clean
> $(RM) $(OUTPUT)util/*-bison*
> $(RM) $(OUTPUT)util/*-flex*
> $(python-clean)
> + $(FIND) . -name "*.o" -exec rm -f {} \;
>
> .PHONY: all install clean strip $(LIBTRACEEVENT)
> .PHONY: shell_compatibility_test please_set_SHELL_PATH_to_a_more_modern_shell
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
