On Tue, Mar 19, 2013 at 10:25 AM, Wanpeng Li <[email protected]> wrote:
> Introduce zero-filled pages handler to capture and handle zero pages.
>
> Acked-by: Dan Magenheimer <[email protected]>
> Signed-off-by: Wanpeng Li <[email protected]>
> ---
> drivers/staging/zcache/zcache-main.c | 26 ++++++++++++++++++++++++++
> 1 files changed, 26 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/zcache/zcache-main.c
> b/drivers/staging/zcache/zcache-main.c
> index 328898e..d73dd4b 100644
> --- a/drivers/staging/zcache/zcache-main.c
> +++ b/drivers/staging/zcache/zcache-main.c
> +static void handle_zero_filled_page(void *page)
> +{
> + void *user_mem;
> +
> + user_mem = kmap_atomic(page);
kmap_atomic() takes a "struct page *", not a "void *".
> + memset(user_mem, 0, PAGE_SIZE);
> + kunmap_atomic(user_mem);
> +
> + flush_dcache_page(page);
While flush_dcache_page() is a no-op on many architectures, it also
takes a "struct page *", not a "void *":
m68k/allmodconfig:
drivers/staging/zcache/zcache-main.c:309:2: error: request for member
'virtual' in something not a structure or union
Cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/8433711/
> +}
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
