3.2-stable review patch. If anyone has any objections, please let me know.
------------------ From: CQ Tang <cq.t...@intel.com> commit 66db3feb486c01349f767b98ebb10b0c3d2d021b upstream. The increment of "to" in copy_user_handle_tail() will have incremented before a failure has been noted. This causes us to skip a byte in the failure case. Only do the increment when assured there is no failure. Signed-off-by: CQ Tang <cq.t...@intel.com> Link: http://lkml.kernel.org/r/20130318150221.8439.993.st...@phlsvslse11.ph.intel.com Signed-off-by: Mike Marciniszyn <mike.marcinis...@intel.com> Signed-off-by: H. Peter Anvin <h...@linux.intel.com> Signed-off-by: Ben Hutchings <b...@decadent.org.uk> --- arch/x86/lib/usercopy_64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/arch/x86/lib/usercopy_64.c +++ b/arch/x86/lib/usercopy_64.c @@ -169,10 +169,10 @@ copy_user_handle_tail(char *to, char *fr char c; unsigned zero_len; - for (; len; --len) { + for (; len; --len, to++) { if (__get_user_nocheck(c, from++, sizeof(char))) break; - if (__put_user_nocheck(c, to++, sizeof(char))) + if (__put_user_nocheck(c, to, sizeof(char))) break; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
