On 03/27/2013 01:20 AM, Linus Walleij wrote: > On Wed, Mar 6, 2013 at 10:49 PM, Darren Hart <[email protected]> wrote: > >> The E6xx (TunnelCreek) CPUs have 9 GPIO lines in the resume well. Update >> the resume functions to allow for more than 8 GPIO lines, using the core >> functions as a template. >> >> Cc: <[email protected]> # 3.4.x >> Cc: <[email protected]> # 3.8.x >> Cc: Grant Likely <[email protected]> >> Cc: Linus Walleij <[email protected]> >> Signed-off-by: Darren Hart <[email protected]> > > I have applied this for next (v3.10) > > I cannot for my life figure out what kind of *regression* you are > fixing so that it should go into fixes for the -rc:s or the two stable > branches indicated above.
I apologize. This is not a regression, it has always been broken for the TunnelCreek (which was added later). With only 8 bits for the resume well, trying to read the 9th GPIO line always fails. I suspect it was just never tested or needed until a board came along using it. As adding support for new systems is acceptable for stable, I felt this landed in that bucket, as well as the "obvious bug fix" bucket. > I need a more verbose commit message with descriptions of > user-percieved problems on deployed systems that for that. Would you like me to resubmit with a more verbose commit message? Happy to do so. > BTW: are you interested in adding yourself as mainatiner of > this driver in the MAINTAINERS file Darren? That might make sense. I'm doing a lot of TunnelCreek driver fixes for the MinnowBoard. If that would be helpful, I'm willing. Thanks, -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
