On Tue, Mar 19, 2013 at 03:46:03PM +0800, Wenyou Yang wrote: > +static void atmel_spi_lock(struct atmel_spi *as) > +{ > + spin_lock_irqsave(&as->lock, as->flags); > +}
Coding style. > - spin_unlock(&as->lock); > + atmel_spi_unlock(as); > msg->complete(msg->context); > - spin_lock(&as->lock); > + atmel_spi_lock(as); This replaces non-irqsave versions with irqsave versions of the lock. Is this safe/correct? If it is I'd have expected some sort of mention of it in the commit log.
signature.asc
Description: Digital signature