On Mon, Apr 08, 2013 at 05:15:26PM +0530, Girish KS wrote: > On Mon, Apr 8, 2013 at 3:45 PM, Mark Brown
> > Two options here, one is to just assume nobody will use GPIO 0 and the > > other is to set the number appopriately during probe so that only probe > > needs to worry about the issue. > > In the second option if the gpio number is set in the probe, then we > are overwriting the > actual gpio number assigned in the platform data. > If I move the cs_gpio from the platform data to controller private > data then the dependency > on other platforms can be removed, but still the check (true or false) > before setting the gpio > line will remain. If agreed upon this i can go ahead and post the patch I think logic in probe should be fine, it just felt really cumbersome having this on every single use but doing it once on probe ought to be OK.
signature.asc
Description: Digital signature