On Mon, Apr 8, 2013 at 5:50 PM, Mark Brown <broo...@opensource.wolfsonmicro.com> wrote: > On Mon, Apr 08, 2013 at 05:15:26PM +0530, Girish KS wrote: >> On Mon, Apr 8, 2013 at 3:45 PM, Mark Brown > >> > Two options here, one is to just assume nobody will use GPIO 0 and the >> > other is to set the number appopriately during probe so that only probe >> > needs to worry about the issue. >> >> In the second option if the gpio number is set in the probe, then we >> are overwriting the >> actual gpio number assigned in the platform data. >> If I move the cs_gpio from the platform data to controller private >> data then the dependency >> on other platforms can be removed, but still the check (true or false) >> before setting the gpio >> line will remain. If agreed upon this i can go ahead and post the patch > > I think logic in probe should be fine, it just felt really cumbersome > having this on every single use but doing it once on probe ought to be > OK.
I will move the populating cs_gpio logic to probe. But the enable_cs and disable_cs will have the check before calling the gpio_set_value api (because it takes cs-line as a parameter), -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/