Hi All,

A minor bug was spotted, as shown blow. The fix will be submitted with the
next version.

> +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb
> *lrbp)
> +{
> +     u32 upiu_flags;
> +     int ret = 0;
> +
> +     if (!lrbp) {
> +             dev_err(hba->dev, "%s: lrbp can not be NULL\n", __func__);
> +             ret = -EINVAL;
> +     } else if (!lrbp->ucd_req_ptr) {
> +             dev_err(hba->dev, "%s: ucd_req_ptr can not be NULL\n",
> +                     __func__);
> +             ret = -EINVAL;
> +     } else if (!lrbp->utr_descriptor_ptr) {
> +             dev_err(hba->dev, "%s: utr_descriptor_ptr can not be NULL\n",
> +                     __func__);
> +             ret = -EINVAL;
> +     }
> +     if (!ret)
> +             goto exit;
should be:
if (ret)

Thanks,
Dolev

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to