From: Michał Mirosław <mir...@gmail.com> Date: Thu, 2 May 2013 19:47:25 +0200
> 2013/5/2 David Miller <da...@davemloft.net>: >> From: Dan Williams <d...@redhat.com> >> Date: Thu, 02 May 2013 11:34:27 -0500 >> >>> On Wed, 2013-05-01 at 18:28 -0700, Linus Torvalds wrote: >>>> On Wed, May 1, 2013 at 1:47 PM, David Miller <da...@davemloft.net> wrote: >>>> > >>>> > Highlights (1721 non-merge commits, this has to be a record of some >>>> > sort): >>>> >>>> Lowlight: it completely breaks my machine with r8169 ethernet. In the >>>> networkmanager applet, it claims no cable connection, which is a bit >>>> odd, because (a) it works with an older kernel and (b) the kernel >>>> messages actually say >>>> >>>> r8169 0000:01:00.0 eth0: link up >>> >>> NM calls ETHTOOL_GLINK and if that returns success, NM expects the >>> driver to support carrier detection. NM then listens to netlink for >>> device flags changes, and uses IFF_LOWER_UP to determine carrier on/off >>> state. NM does not use NETIF_F_VLAN_CHALLENGED or any of the other >>> ETHTOOL_GFEATURES flags yet, but will in the future. >>> >>> Is the link status accurately reflected by /sys/class/net/eth0/carrier ? >> Something cares about the .../eth0/flags value because with the bit >> ordering different for bits 10 and above things break. > > Are you sure it's "flags"? /sys/class/net/*/features were removed some > time ago, and flags don't depend on NETIF_F_*. Oh, it's flags, which is printed in raw hex by net/core/net-sysfs.c: NETDEVICE_SHOW(flags, fmt_hex); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/