On Mon, May 6, 2013 at 4:30 PM, Linus Torvalds <torva...@linux-foundation.org> wrote: > On Mon, May 6, 2013 at 5:31 AM, Geert Uytterhoeven <ge...@linux-m68k.org> > wrote: >> >> How should this be fixed? >> - Re-add SYMBOL_NAME() to arch/h8300/include/asm/linkage.h? > > No. The whole point was to *not* have these random private definitions. > > I guess you could use VMLINUX_SYMBOL() and include <linux/export.h> > and then use VMLINUX_SYMBOL(). Although.. > >> - Kill SYMBOL_NAME() and SYMBOL_NAME_LABEL(), and hardcode the >> underscores in the h8300 asm sources? > > .. I think this is what everybody else does. Although sometimes that > underscore depends on what the linkage format is (ie historically > a.out vs elf etc). We pretty much expect ELF these days, but maybe > other conditional reasons exist - so there may be a reason you don't > want to do the hardcoding (although on h8300 it seems to be > unconditional at least for now).
Thx, will fix. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/