Guenter Roeck <li...@roeck-us.net> writes:
> Hi all,
>
> I started seeing build failures such as the following in the last week or so.
>
> make[2]: [__modpost] Error 1
>
> followed by lots of messages such as
>
> gcc: error: arch/x86/crypto/ablk_helper.mod.c: No such file or directory
> gcc: fatal error: no input files
>
> (at least if I run make -i)
Hmm, weird! Looks like __modules contains something it shouldn't. We
changed from:
__modules := $(sort $(shell grep -h '\.ko$$' /dev/null $(wildcard
$(MODVERDIR)/*.mod)))
To:
MODLISTCMD := find $(MODVERDIR) -name '*.mod' | xargs -r grep -h
'\.ko$$' | sort -u
__modules := $(shell $(MODLISTCMD))
They give the same results for me:
diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
index 8dcdca2..1ca358d 100644
--- a/scripts/Makefile.modpost
+++ b/scripts/Makefile.modpost
@@ -62,8 +62,14 @@ modulesymfile := $(firstword $(KBUILD_EXTMOD))/Module.symvers
# Step 1), find all modules listed in $(MODVERDIR)/
MODLISTCMD := find $(MODVERDIR) -name '*.mod' | xargs -r grep -h '\.ko$$' |
sort -u
__modules := $(shell $(MODLISTCMD))
+__old_modules := $(sort $(shell grep -h '\.ko$$' /dev/null $(wildcard
$(MODVERDIR)/*.mod)))
modules := $(patsubst %.o,%.ko, $(wildcard $(__modules:.ko=.o)))
+.PHONY: dump_modules
+dump_modules:
+ @echo $(__modules) > __modules.list
+ @echo $(__old_modules) > __old_modules.list
+
# Stop after building .o files if NOFINAL is set. Makes compile tests quicker
_modpost: $(if $(KBUILD_MODPOST_NOFINAL), $(modules:.ko:.o),$(modules))
@@ -84,7 +90,7 @@ quiet_cmd_modpost = MODPOST $(words $(filter-out vmlinux
FORCE, $^)) modules
cmd_modpost = $(MODLISTCMD) | sed 's/\.ko$$/.o/' | $(modpost) -s -T -
PHONY += __modpost
-__modpost: $(modules:.ko=.o) FORCE
+__modpost: $(modules:.ko=.o) dump_modules FORCE
$(call cmd,modpost) $(wildcard vmlinux)
quiet_cmd_kernel-mod = MODPOST $@
> After reverting commit ea4054a238 (modpost: handle huge numbers of modules)
> everything is fine.
>
> This happens with multiple gcc versions and target platforms (arm, x86_64,
> i386, powerpc). Host kernel version is 3.8.10, system is Ubuntu 12.10.
>
> Does anyone else see this problem ? Any idea what might be wrong ?
Assuming it happens with a clean tree, please send the .config, and I'll
see if I can reproduce...
Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
