On 12/05/2013, at 7:06 PM, Russell King - ARM Linux <li...@arm.linux.org.uk>
wrote:
> On Sun, May 12, 2013 at 02:22:56PM +1000, Daniel Tang wrote:
>>
>> + .bpp = 8,
>> + .grayscale = 1
>> +};
>
> Still no capabilities in the above - how does the CLCD controller know
> which of BGR or RGB output and which format these panels support?
>
> Each entry needs a .caps = CLCD_CAP_xxx | CLCD_CAP_xxx listing the
> formats supported there.
>
> Unless panels and the board have a .caps entry, the caps system won't
> be used.
Fair enough.
>
>> +static struct clcd_board nspire_clcd_data = {
>> + .name = "LCD",
>> + .caps = CLCD_CAP_ALL,
>
> Your board has logic to support the RGB444/BGR444 mode? If not, setting
> CLCD_CAP_ALL is incorrect.
I believe the grayscale panel supports the xGx444 modes - unsure about the
colour one. Since I'm using the same struct clcd_board for both panels, I
thought I'd just set caps to work with both to simplify.
Should I set board caps to panel caps on setup?
Cheers,--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
