On Fri, May 17, 2013 at 10:48:06AM +0100, Mel Gorman wrote:
> Now that the LRU to add a page to is decided at LRU-add time, remove the
> misleading lru parameter from __pagevec_lru_add. A consequence of this is
> that the pagevec_lru_add_file, pagevec_lru_add_anon and similar helpers
> are misleading as the caller no longer has direct control over what LRU
> the page is added to. Unused helpers are removed by this patch and existing
> users of pagevec_lru_add_file() are converted to use lru_cache_add_file()
> directly and use the per-cpu pagevecs instead of creating their own pagevec.
> 
> Signed-off-by: Mel Gorman <mgor...@suse.de>
> Reviewed-by: Jan Kara <j...@suse.cz>
> Reviewed-by: Rik van Riel <r...@redhat.com>

> @@ -452,8 +448,7 @@ int cachefiles_read_or_alloc_page(struct 
> fscache_retrieval *op,
>       if (block) {
>               /* submit the apparently valid page to the backing fs to be
>                * read from disk */
> -             ret = cachefiles_read_backing_file_one(object, op, page,
> -                                                    &pagevec);
> +             ret = cachefiles_read_backing_file_one(object, op, page);

Also remove the declaration and pagevec_init a few lines up?  Minor
detail, though.

Acked-by: Johannes Weiner <han...@cmpxchg.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to