Hi Axel,
Thank you for the patch.
On Sunday 19 May 2013 13:45:31 Axel Lin wrote:
> Signed-off-by: Axel Lin <axel....@ingics.com>
> ---
> drivers/pwm/pwm-renesas-tpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
> index 8e6d8d7..351addd 100644
> --- a/drivers/pwm/pwm-renesas-tpu.c
> +++ b/drivers/pwm/pwm-renesas-tpu.c
> @@ -444,7 +444,7 @@ static int tpu_remove(struct platform_device *pdev)
>
> pm_runtime_disable(&pdev->dev);
>
> - return 0;
> + return pwmchip_remove(&tpu->chip);
Could you please move that line at the beginning of the function ? There would
be a race condition otherwise, as the user could reenable PWM between the
tpu_pwm_timer_stop() calls and the pwmchip_remove() call.
Apart from that, the patch looks good.
> }
>
> static struct platform_driver tpu_driver = {
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
