On Wed, 15 May 2013, Leon Romanovsky wrote: > There is no need to call kfree while using devm_kzalloc, > remove it from *_device_init function. > > Signed-off-by: Leon Romanovsky <l...@leon.nu> > --- > drivers/mfd/tps65912-core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c > index aeb8e40..f25e552 100644 > --- a/drivers/mfd/tps65912-core.c > +++ b/drivers/mfd/tps65912-core.c > @@ -127,7 +127,8 @@ int tps65912_device_init(struct tps65912 *tps65912) > struct tps65912_platform_data *init_data; > int ret, dcdc_avs, value; > > - init_data = kzalloc(sizeof(struct tps65912_platform_data), GFP_KERNEL); > + init_data = devm_kzalloc(&tps65912->dev, > + sizeof(struct tps65912_platform_data), GFP_KERNEL);
On second thoughts, have you actually built this? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
