On Tue, May 28, 2013 at 12:31 AM, Joe Perches <j...@perches.com> wrote: > > I think the __alloc_skb alloc failure message is ok, > but maybe there shouldn't be something "scary" like > a dump_stack. > > Maybe this site should use a trivial debug error > message like below instead.
The stack trace may or may not be important for debugging, however what is important is that we know how often this is happening. That implies that there should be a percpu counter of allocation failures here, regardless of a dump_stack, rate limited or not. I would suppose it's ok for no stack by default as long as there is a counter, for this specific call only. There are some scary ways this code is called, for example from tcp_send_fin(). It does yield() in that loop, but otherwise it just spins. -Deb -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
