On 05/30/2013 03:09 PM, Andreas Schwab wrote: > Chen Gang <[email protected]> writes: > >> > 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original >> > author wanted to check the highest bit whether set. >> > >> > So need type cast form 'unsigned long' to 'long'. > Better to make the bit test explicit, since it is not a sign bit. >
That sounds good. >> > diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c >> > index 08f286d..ef013c5 100644 >> > --- a/arch/m68k/math-emu/fp_arith.c >> > +++ b/arch/m68k/math-emu/fp_arith.c >> > @@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode) >> > return; >> > break; >> > case 0x401e: >> > - if (!(oldmant.m32[1] >= 0)) >> > + if (!((long)oldmant.m32[1] >= 0)) > if (oldmant.m32[1] & 0x80000000) OK, I will send patch v2. Thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
