On Thu, Jun 06, 2013 at 01:52:21PM -0700, Kees Cook wrote: > The exposed interface for cm_notify_event() could result in the event > msg string being parsed as a format string. Make sure it is only used > as a literal string. > > Signed-off-by: Kees Cook <keesc...@chromium.org> > Cc: sta...@vger.kernel.org > Cc: Anton Vorontsov <c...@mail.ru> > Cc: David Woodhouse <dw...@infradead.org> > ---
Thanks a lot, Kees! This is now applied. > drivers/power/charger-manager.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c > index fefc39f..98de1dd 100644 > --- a/drivers/power/charger-manager.c > +++ b/drivers/power/charger-manager.c > @@ -450,7 +450,7 @@ static void uevent_notify(struct charger_manager *cm, > const char *event) > strncpy(env_str, event, UEVENT_BUF_SIZE); > kobject_uevent(&cm->dev->kobj, KOBJ_CHANGE); > > - dev_info(cm->dev, event); > + dev_info(cm->dev, "%s", event); > } > > /** > -- > 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
