From: "Michael S. Tsirkin" <m...@redhat.com> Date: Thu, 13 Jun 2013 10:07:29 +0300
> commit df8ef8f3aaa6692970a436204c4429210addb23a > "macvlan: add FDB bridge ops and macvlan flags" > added a way to control NOPROMISC macvlan flag through netlink. > > However, with a non passthrough device we never set promisc on open, > even if NOPROMISC is off. As a result: > > If userspace clears NOPROMISC on open, then does not clear it on a > netlink command, promisc counter is not decremented on stop and there > will be no way to clear it once macvlan is detached. > > If userspace does not clear NOPROMISC on open, then sets NOPROMISC on a > netlink command, promisc counter will be decremented from 0 and overflow > to fffffffff with no way to clear promisc. > > To fix, simply ignore NOPROMISC flag in a netlink command for > non-passthrough devices, same as we do at open/close. > > Since we touch this code anyway - check dev_set_promiscuity return code > and pass it to users (though an error here is unlikely). > > Cc: "David S. Miller" <da...@davemloft.net> > Reviewed-by: John Fastabend <john.r.fastab...@intel.com> > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
