Looks good to me.
> -----Original Message----- > From: Ralf Baechle [mailto:[email protected]] > Sent: Thursday, June 13, 2013 11:43 AM > To: Matt Porter; Bounine, Alexandre; [email protected] > Subject: [PATCH] RAPIDIO: Fix idt_gen2.c build > > idt_gen2.c relies that one of the header files used will include > <asm/page.h> which will define the required symbol PAGE_SIZE. On MIPS > for example <asm/page.h> will not be included implicitly which will > result in the following build error: > > CC drivers/rapidio/switches/idt_gen2.o > drivers/rapidio/switches/idt_gen2.c: In function ‘idtg2_show_errlog’: > drivers/rapidio/switches/idt_gen2.c:379:30: error: ‘PAGE_SIZE’ > undeclared (first use in this function) > drivers/rapidio/switches/idt_gen2.c:379:30: note: each undeclared > identifier is reported only once for each function it appears in > > Signed-off-by: Ralf Baechle <[email protected]> > --- > > If you're ok with this patch I can put it into my next pull request for > Linux. Thanks! > > > drivers/rapidio/switches/idt_gen2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/rapidio/switches/idt_gen2.c > b/drivers/rapidio/switches/idt_gen2.c > index 809b7a3..5d3b0f0 100644 > --- a/drivers/rapidio/switches/idt_gen2.c > +++ b/drivers/rapidio/switches/idt_gen2.c > @@ -15,6 +15,8 @@ > #include <linux/rio_drv.h> > #include <linux/rio_ids.h> > #include <linux/delay.h> > + > +#include <asm/page.h> > #include "../rio.h" > > #define LOCAL_RTE_CONF_DESTID_SEL 0x010070
