On Tue, May 28, Haiyang Zhang wrote: > Since the recent addition of 8021AD, we need to set the new field vlan_proto > in > sk_buff. Otherwise, it will trigger BUG() call in vlan_proto_idx().
> @@ -284,7 +285,7 @@ int netvsc_recv_callback(struct hv_device *device_obj, > > skb->protocol = eth_type_trans(skb, net); > skb->ip_summed = CHECKSUM_NONE; > - skb->vlan_tci = packet->vlan_tci; > + __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), packet->vlan_tci); Just curious: Doesnt that change behaviour in the sense that __vlan_hwaccel_put_tag() now always adds VLAN_TAG_PRESENT to skb->vlan_tci, while before that change packet->vlan_tci may or may not had this flag? In other words, should a variant of this patch be backported if it was a bug not not use __vlan_hwaccel_put_tag right from the start? Olaf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
