On 06/17/2013 02:24 PM, Alan Stern wrote: > On Mon, 17 Jun 2013, Shuah Khan wrote: > >> Change __device_suspend() path to include driver name and the ops that >> get run for a device. This additional information helps associate the >> driver and the type of pm_ops the device uses in the suspend path very >> quickly, which will aid in debugging problems in suspend and resume paths. >> Changed both start and end debug messages to include pm_ops information >> and use dev_info() instead of pr_info(). Changed the end message to include >> parent device information and have the same format as the start message. >>
>> >> [ 546.087069] rtc_cmos 00:05: Start: legacy bus pm ops @ 2391, parent: pnp0 >> [ 546.087084] rtc_cmos 00:05: End : legacy bus pm ops @ 2391, parent: pnp0 >> time(11 usecs) err(0) > > If you don't mind a little more bike-shedding, I suggest formatting the > return value and time in a shorter format, like this: > > [ 545.987650] usb 1-1: End : type pm ops @ 68, parent: usb1 -> 0, 2184 us > > Alan Stern > > I am leaning towards leaving it the way it is for clarity, even though it is a bit longer? Changing it would make it too cryptic especially error return. thanks, -- Shuah Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research America (Silicon Valley) [email protected] | (970) 672-0658 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
