On Thu, Jun 27, 2013 at 10:25 AM, Arnd Bergmann <[email protected]> wrote: > On Thursday 27 June 2013 09:07:29 Geert Uytterhoeven wrote: >> On Thu, Jun 27, 2013 at 6:37 AM, Chen Gang <[email protected]> wrote: >> > --- a/arch/m32r/include/asm/io.h >> > +++ b/arch/m32r/include/asm/io.h >> > @@ -169,6 +169,20 @@ static inline void _writel(unsigned long l, unsigned >> > long addr) >> > #define iowrite16 writew >> > #define iowrite32 writel >> > >> > +#define ioread8_rep(p, dst, count) \ >> > + insb((unsigned long) (p), (dst), (count)) >> >> As ioread8() is mapped to readb() (I/O memory space), not inb() (I/O >> port space), >> ioread8_rep() should map to readsb() (which m32r doesn't have yet >> BTW), not insb(). >> For m32r this does matter, as inb() and readb() use different mechanisms >> internally. >> >> It seems include/asm-generic/io.h also has this wrong? > > Yes, you are right. I thought we had fixed that long ago. > > Does the patch below look ok to you? Note that none of the architectures > using asm-generic/io.h supports PIO access and it works by chance > this way, but we should definitely fix it. > > Signed-off-by: Arnd Bergmann <[email protected]>
Acked-by: Geert Uytterhoeven <[email protected]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
