[PATCH v1 2/4] spi/xilinx: Clean ioremap calling

[Michal Simek]

devm_ioremap_resource() automatically checks that
struct resource is initialized.
Also group platform_get_resource() and devm_ioremap_resource()
together.
And remove mem resource from struct xilinx_spi.

Signed-off-by: Michal Simek <michal.si...@xilinx.com>
---
 drivers/spi/spi-xilinx.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
index f3de5e5..c99c37b 100644
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -80,7 +80,6 @@ struct xilinx_spi {
        /* bitbang has to be first */
        struct spi_bitbang bitbang;
        struct completion done;
-       struct resource mem; /* phys mem */
        void __iomem    *regs;  /* virt. address of the control registers */

        u32             irq;
@@ -363,7 +362,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
 {
        struct xilinx_spi *xspi;
        struct xspi_platform_data *pdata;
-       struct resource *r;
+       struct resource *res;
        int ret, irq, num_cs = 0, bits_per_word = 8;
        struct spi_master *master;
        u32 tmp;
@@ -392,10 +391,6 @@ static int xilinx_spi_probe(struct platform_device *pdev)
                return -EINVAL;
        }

-       r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!r)
-               return -ENODEV;
-
        irq = platform_get_irq(pdev, 0);
        if (irq < 0)
                return -ENXIO;
@@ -415,7 +410,8 @@ static int xilinx_spi_probe(struct platform_device *pdev)
        xspi->bitbang.master->setup = xilinx_spi_setup;
        init_completion(&xspi->done);

-       xspi->regs = devm_ioremap_resource(&pdev->dev, r);
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       xspi->regs = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(xspi->regs)) {
                ret = PTR_ERR(xspi->regs);
                goto put_master;
@@ -425,7 +421,6 @@ static int xilinx_spi_probe(struct platform_device *pdev)
        master->num_chipselect = num_cs;
        master->dev.of_node = pdev->dev.of_node;

-       xspi->mem = *r;
        xspi->irq = irq;

        /*
@@ -477,7 +472,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
        }

        dev_info(&pdev->dev, "at 0x%08llX mapped to 0x%p, irq=%d\n",
-               (unsigned long long)r->start, xspi->regs, xspi->irq);
+               (unsigned long long)res->start, xspi->regs, xspi->irq);

        if (pdata) {
                for (i = 0; i < pdata->num_devices; i++)
--
1.8.2.3

pgpYWP0t_oncd.pgp
Description: PGP signature