2013/7/9 Mark Brown <broo...@kernel.org>: > On Tue, Jul 09, 2013 at 04:25:28PM +0200, Richard Genoud wrote: >> This add the sound DT binding for sam9x5ek-wm8731 machine driver >> >> Signed-off-by: Richard Genoud <richard.gen...@gmail.com> >> --- >> .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 30 >> ++++++++++++++++++++ > > Put new binding documents in the same patch that reads them, this makes > review easier. ok, I'll squash it with patch 1
>> + - atmel,audio-routing: A list of the connections between audio components. > > This needs to be more specific and list the available board specific > nodes for routing. For the CODEC you can just refer to the CODEC > binding documentation. Ok, I'll do that. >> + - atmel,format: DAI format. Must be "i2s" > > So why not just omit this then? Will be removed. > >> + - atmel,bitclock-master: DAI clock master >> + - atmel,frame-master: DAI frame master > > The driver isn't handling these and there's no information on how to set > them. They will also go away. Thanks ! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
