On Wed, Jul 17, 2013 at 4:40 PM, Ben Myers <b...@sgi.com> wrote: >> >> We're still talking at cross purposes then. >> >> How the hell do you handle mmap() and page faulting? > > __xfs_get_blocks serializes access to the block map with the i_lock on the > xfs_inode. This appears to be racy with respect to hole punching.
Would it be possible to just make __xfs_get_blocks get the i_iolock (non-exclusively)? Or, alternatively, do it in the readpage() function? That was what I thought you did anyway. Exactly because of the whole page faulting issue. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/