On Mon, 29 Jul 2013 11:49:31 +0000 Chereji Marian-Cornel-R27762 <[email protected]> wrote:
> -----Original Message----- > From: Andrew Morton [mailto:[email protected]] > Sent: Saturday, July 27, 2013 1:01 AM > To: Chereji Marian-Cornel-R27762 > Cc: [email protected]; Grigore Sebastian-SGRIGOR1; Schmitt > Richard-B43082; Fleming Andy-AFLEMING > Subject: Re: [PATCH] lib: Add CRC64 ECMA module > > On Fri, 12 Jul 2013 11:56:26 +0300 Marian Chereji > <[email protected]> wrote: > > > Added implementation of CRC64 ECMA checksum. > > > > Signed-off-by: Marian Chereji <[email protected]> > > Reviewed-by: Varvara Andrei-B21317 <[email protected]> > > Reviewed-by: Fleming Andrew-AFLEMING <[email protected]> > > --- > > include/linux/crc64_ecma.h | 56 +++++++ > > lib/Kconfig | 7 + > > lib/Makefile | 1 + > > lib/crc64_ecma.c | 341 > > ++++++++++++++++++++++++++++++++++++++++++++ > > > > Presumably you have some code which will need this library feature? > > > > What code is that, and what is its status? > > > > Hi Andrew, > > we have an IP Acceleration driver for Freescale network processors > which is using this CRC64. However, it still needs some work in > order for it to become upstreamable. > > Thought this CRC64 could helps others in the meantime since it doesn't > have anything specific to do with our driver. Please don't top-post - it makes it very hard to conduct a conversation. I don't think it's generally desirable to put code into lib/ unless we have an in-kernel user: it consumes resources and is untestable. From a quick grep I don't see any current in-kernel code which might use this. So I'd propose that I keep this patch in -mm to get a bit of exposure and compilation testing and wait until the first user comes along, OK? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
