From: Joe Perches <j...@perches.com>
Date: Wed, 31 Jul 2013 11:56:38 -0700
>> + if (ui & (RX_ERR | CRC_ERR | FTL | RUNT | RX_ODD_NB)) {
>> + netdev_err(ndev, "packet error\n");
>
> This is generally a bad idea as it can flood
> the log. It's probably better to remove it.
> If you really want logging, then at least use
> net_ratelimit(). Generally, the stats are
> enough.
...
>> + priv->stats.rx_dropped++;
>> + priv->stats.rx_errors++;
> []
>> +static int moxart_mac_start_xmit(struct sk_buff *skb, struct net_device
>> *ndev)
> []
>> + if (txdesc->txdes0.ubit.tx_dma_own) {
>> + netdev_err(ndev, "no TX space for packet\n");
>> + priv->stats.tx_dropped++;
>
> here too.
Agreed, these should not be logged, the statistics are sufficient.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
