On Mon, Aug 05, 2013 at 10:58:13AM +0800, Li Zefan wrote:
> > +struct cgroup *__cgroup_from_dentry(struct dentry *dentry, struct cftype 
> > **cftp)
> >  {
> > -   if (file_inode(file)->i_fop != &cgroup_file_operations)
> > -           return ERR_PTR(-EINVAL);
> > -   return __d_cft(file->f_dentry);
> > +   if (!dentry->d_inode ||
> > +       dentry->d_inode->i_op != &cgroup_file_inode_operations)
> > +           return NULL;
> > +
> > +   if (cftp)
> > +           *cftp = __d_cft(dentry);
> > +   return __d_cgrp(dentry->d_parent);
> >  }
> > +EXPORT_SYMBOL_GPL(__cgroup_from_dentry);
> 
> As we don't expect new users, why export this symbol? memcg can't be
> built as a module.

Yeah, I for some reason was thinking memcg could be bulit as module.
Brainfart.  Dropped.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to