On 08/21, Chen Gang wrote: > > On 08/20/2013 10:37 PM, Oleg Nesterov wrote: > > On 08/20, Serge Hallyn wrote: > >> > >> > >> But the only existing caller (sys_unshare) does in fact initialize it to > >> NULL. So while this patch does no harm, is it necessary? > > > > Agreed. > > > > Plus, with this patch unshare_userns() becomes "inconsistent" compared > > to other unshare_ helpers. > > > > Hmm... for static functions, they don't need, but for extern functions, > recommend to do so. > > > For "unshare_ helpers", I find 3 extern functions: > > unshare_files() which already set value. > unshare_userns() and unshare_nsproxy_namespaces() which not set. > > In my opinion, recommend to always set the return parameter when > succeed, for the 2 left extern functions.
I do not think that static/extern should make any difference. To me, the cleanup should make unshare_userns() return "cred *" (or NULL or ERR_PTR()) But this is subjective and in this case we should change other unshare_ helpers too. Doesn't worth the trouble. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
