> > Since 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from > > platform data", .set_pwr() callback is removed from platform data. > > Thus, .set_pwr() is not used anymore. Also, this patch fixes > > the following build error and warning. > > > > drivers/mfd/asic3.c:724:2: error: unknown field 'set_pwr' specified in > > initializer drivers/mfd/asic3.c:724:2: warning: initialization makes > > integer from pointer without a cast [enabled by default] > > drivers/mfd/asic3.c:724:2: warning: (near initialization for > > 'asic3_mmc_data.capabilities' [enabled by default] > > My bad, it looks like I've overlooked a few users of the .set_pwr() field :-/ > Sorry about that.
<snip> > I don't think blindly removing the function is the right fix, as it seems to > be needed. Looking at the whole series, I believe we should just revert > 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from platform data" > instead. No need to revert it, as it's not in Mainline yet. Just request for it to be removed from Chris' tree. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/