Hi Lee, (Dropping Ian Molton <ian.mol...@collabora.co.uk> from the CC list as the e- mail address isn't valid anymore)
On Wednesday 28 August 2013 08:41:26 Lee Jones wrote: > > > Since 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from > > > platform data", .set_pwr() callback is removed from platform data. > > > Thus, .set_pwr() is not used anymore. Also, this patch fixes > > > the following build error and warning. > > > > > > drivers/mfd/asic3.c:724:2: error: unknown field 'set_pwr' specified in > > > initializer drivers/mfd/asic3.c:724:2: warning: initialization makes > > > integer from pointer without a cast [enabled by default] > > > drivers/mfd/asic3.c:724:2: warning: (near initialization for > > > 'asic3_mmc_data.capabilities' [enabled by default] > > > > My bad, it looks like I've overlooked a few users of the .set_pwr() field > > :-/ Sorry about that. > > <snip> > > > I don't think blindly removing the function is the right fix, as it seems > > to be needed. Looking at the whole series, I believe we should just > > revert 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from platform > > data" instead. > > No need to revert it, as it's not in Mainline yet. Just request for it > to be removed from Chris' tree. I spupose it depends on whether Chris has provided a stable branch with the patch included. I'm fine with both, the commit just needs to be undone one way or another. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
