On Thursday, August 29, 2013 10:19 AM, Anton Vorontsov wrote: > On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: > > He doesn't want to take the patch. He's the maintainer so it's his > > choice. That's the end of the story. > > Just to clarify: I don't want to take the patch for a reason, not just > because of my mood today. Once the patch comes in combination with another > patch (or a plan) that actually makes use of the wrapper function, then > I'd happily apply/ack it.
Sorry, I cannot understand. This patch is a just cosmetic change. I cannot understand why you reject it. > > This is the same story as global checkpatch.pl fixes: they are more harm > than good, and without the actual use of the dev_get_platdata(), the patch > falls into "global checkpatch.pl fixes" category. So, what is the harm of the fix using dev_get_platdata() wrapper function? What is "the actual use of the dev_get_platdata()"? Please, give me more detailed description. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/