On Mon, Sep 02, 2013 at 03:39:45PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 2 Sep 2013 11:19:01 -0700 > Josh Triplett <[email protected]> escreveu: > > > Patches to checkpatch that add new style rules should also change > > Documentation/CodingStyle to document those new style rules; add a > > comment to that effect to the top of scripts/checkpatch.pl. > > Well, you forgot to c/c LKML on this patch; I think that KS2013 is not the > proper list to review this patch ;)
My mail went to LKML; it had: To: [email protected] > > Signed-off-by: Josh Triplett <[email protected]> > > --- > > scripts/checkpatch.pl | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index 2ee9eb7..ba65ea6 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -4,6 +4,10 @@ > > # (c) 2007,2008, Andy Whitcroft <[email protected]> (new conditions, test > > suite) > > # (c) 2008-2010 Andy Whitcroft <[email protected]> > > # Licensed under the terms of the GNU GPL License version 2 > > +# > > +# This file does not define the kernel coding style; > > Documentation/CodingStyle > > +# does. If you add a new style test to this file, add the corresponding > > style > > +# rule it enforces to Documentation/CodingStyle. > > > > Agreed with that. I would also add another comment there: "in case of > conflicts between checkpatch.pl and Documentation/CodingStyle, the latter > takes precedence." Good point. > Anyway, > > Acked-by: Mauro Carvalho Chehab <[email protected]> Thanks. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
