Em Mon, 02 Sep 2013 12:40:47 -0700
Joe Perches <j...@perches.com> escreveu:
> Add a message describing the lack of value in using
> --file to generate patches.
>
> Exclude files in staging from this message.
>
> A similar message was removed by commit cf655043d4b
> ("update checkpatch.pl to version 0.15")
>
> Signed-off-by: Joe Perches <j...@perches.com>
Acked-by: Mauro Carvalho Chehab <m.che...@samsung.com>
> ---
>
> Maybe this sort of wordsmithing is valuable.
>
> scripts/checkpatch.pl | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9bb056c..f788a14 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4280,6 +4280,19 @@ $vname has style problems, please review.
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> EOM
> + if ($file && $realfile !~ m@\bstaging/@) {
> + print << "EOM";
> +
> +WARNING: When using --file mode, do not send patches that just make
> +whitespace or formatting changes unless more significant changes are
> +also made for other reasons in another patch.
> +
> +Patches that are just code style changes have a real cost.
> +
> +These sort of patches can cause rejects with other changes and are
> +thought of by many maintainers as more harmful and tiresome than useful.
> +EOM
> + }
> }
>
> return $clean;
>
>
> _______________________________________________
> Ksummit-2013-discuss mailing list
> ksummit-2013-disc...@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/ksummit-2013-discuss
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
