On Thu, Sep 05, 2013 at 05:33:24PM +0200, Frederic Weisbecker wrote: > Ksoftirqd shouldn't need softirq stack since it's executing > in a kernel thread with a callstack that is only beginning at > this stage. > > Lets comment about that for clarity. > > Signed-off-by: Frederic Weisbecker <[email protected]> > Cc: Benjamin Herrenschmidt <[email protected]> > Cc: Paul Mackerras <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: H. Peter Anvin <[email protected]> > Cc: Linus Torvalds <[email protected]> > Cc: Paul Mackerras <[email protected]> > Cc: James Hogan <[email protected]> > Cc: James E.J. Bottomley <[email protected]> > Cc: Helge Deller <[email protected]> > Cc: Martin Schwidefsky <[email protected]> > Cc: Heiko Carstens <[email protected]> > Cc: David S. Miller <[email protected]> > Cc: Andrew Morton <[email protected]> > --- > kernel/softirq.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/kernel/softirq.c b/kernel/softirq.c > index 657e047..1de0322 100644 > --- a/kernel/softirq.c > +++ b/kernel/softirq.c > @@ -759,6 +759,7 @@ static void run_ksoftirqd(unsigned int cpu) > { > local_irq_disable(); > if (local_softirq_pending()) { > + /* No need to use softirq stack here */
Looking at that comment now, it probably deserve more details :) > __do_softirq(); > rcu_note_context_switch(cpu); > local_irq_enable(); > -- > 1.7.5.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
