On Fri, Sep 06, 2013 at 10:19:18AM +0100, Leif Lindholm wrote: > --- a/arch/arm/kernel/setup.c > +++ b/arch/arm/kernel/setup.c > @@ -877,6 +878,10 @@ void __init setup_arch(char **cmdline_p) > > parse_early_param(); > > +#ifdef CONFIG_EARLY_IOREMAP > + early_ioremap_init(); > +#endif
Better with a dummy early_ioremap_init() in the header when !CONFIG_EARLY_IOREMAP to avoid the #ifdef here. > --- /dev/null > +++ b/arch/arm/mm/early_ioremap.c > @@ -0,0 +1,271 @@ > +/* > + * early_ioremap() support for ARM > + * > + * Based on existing support in arch/x86/mm/ioremap.c At a very quick look, this looks really close to the x86 implementation. Any reason why this cannot be made generic and avoid duplication? -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
