[adding David Brown] On Fri, Sep 13, 2013 at 05:27:47AM +0100, Michael Opdenacker wrote: > This patch proposes to remove the IRQF_DISABLED flag from > code in drivers/net/ethernet/smsc/ > > It's a NOOP since 2.6.35 and it will be removed one day. > > Signed-off-by: Michael Opdenacker <michael.opdenac...@free-electrons.com> > --- > drivers/net/ethernet/smsc/smc91x.h | 2 +- > drivers/net/ethernet/smsc/smsc9420.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/smsc/smc91x.h > b/drivers/net/ethernet/smsc/smc91x.h > index 370e13d..5730fe2 100644 > --- a/drivers/net/ethernet/smsc/smc91x.h > +++ b/drivers/net/ethernet/smsc/smc91x.h > @@ -271,7 +271,7 @@ static inline void mcf_outsw(void *a, unsigned char *p, > int l) > #define SMC_insw(a, r, p, l) mcf_insw(a + r, p, l) > #define SMC_outsw(a, r, p, l) mcf_outsw(a + r, p, l) > > -#define SMC_IRQ_FLAGS (IRQF_DISABLED) > +#define SMC_IRQ_FLAGS 0
After this change, the only machine that defines the flags to anything other than IRQF_TRIGGER_RISING is MSM, which uses IRQF_TRIGGER_HIGH. David: do you actually need this? The irq_chip code under mach-msm doesn't seem to distinguish between the two. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/