On 09/13/2013 07:37 PM, Andre Naujoks wrote: > The locking is needed, since the the internal buffer for the CAN frames is > changed during the wakeup call. This could cause buffer inconsistencies > under high loads, especially for the outgoing short CAN packet skbuffs. > > The needed locks led to deadlocks before commit > "5ede52538ee2b2202d9dff5b06c33bfde421e6e4 tty: Remove extra wakeup from pty > write() path", which removed the direct callback to the wakeup function from > the > tty layer.
What does that mean for older kernels? (< 5ede52538ee2b2202d9dff5b06c33bfde421e6e4) > As slcan.c is based on slip.c the issue in the original code is fixed, too. > > Signed-off-by: Andre Naujoks <nauts...@gmail.com> Acked-by: Marc Kleine-Budde <m...@pengutronix.de> Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
