On Thu, 2013-09-19 at 17:44 -0700, Brian Norris wrote: > > Does that m25p80 'fix 4 byte addressing' fix for Micron not also want to > > go in? > > I suppose the m25p80 one can go in as well. It's not so much a bugfix > as augmenting my original patch to support more devices. But it is > safe enough.
You say 'support more devices', but AFAICT the code in -rc1 will already *attempt* to enable 4-byte addressing on those devices, and fail. (It looks like set_4byte() can return failure, but its return code isn't checked, and anyway it's only a SPI write so there's no feedback from the *chip* if it fails due to lack of WREN; it can only indicate failure if the SPI connection falls over.) So I'm inclined to think of it as a bug fix and include it. -- David Woodhouse Open Source Technology Centre david.woodho...@intel.com Intel Corporation
smime.p7s
Description: S/MIME cryptographic signature
