Am 29.09.2013 00:14, schrieb Elad Wexler: > On Sat, Sep 28, 2013 at 08:54:55PM +0200, richard -rw- weinberger wrote: >> On Sat, Sep 28, 2013 at 8:14 PM, <elad.wex...@gmail.com> wrote: >>> From: Elad Wexler <elad.wex...@gmail.com> >>> >>> Driver doesn't do anything special in 'module_init'. >>> >>> 'module_platform_init' makes the code more readable. >>> >>> Signed-off-by: Elad Wexler <elad.wex...@gmail.com> >> >> NAK. >> >> By moving to module_platform_init() you make this module unloadable. >> Currently it is unloadable for good reasons. >> The cs5535-mfgpt chip is nasty because it has no reliable reset function. >> Therefore by unloading and loading the module again bad things can happen. >> > I think this HW information should be well documented. > Explaining the reason why it doesn't implemented the 'module_exit'
Usually if a driver does not implement the exit function it's because of hardware limitations. IOW, the alarm bell rings. ;-) Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
